Backport of followup fix for "Cygwin: try to avoid recalling offline files" #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If FILE_DIRECTORY_FILE is given, FILE_OPEN_NO_RECALL is not allowed, otherwise NtCreateFile returns STATUS_INVALID_PARAMETER. Drop FILE_OPEN_NO_RECALL where FILE_DIRECTORY_FILE is specified. Fixes: f6b56ab ("Cygwin: try to avoid recalling offline files") Reported-by: Bruce Jerrick <[email protected]> Signed-off-by: Corinna Vinschen <[email protected]>
lazka
changed the title
lazka
changed the title
dscho
approved these changes
Apr 6, 2024
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Apr 6, 2024
This integrates msys2/msys2-runtime#210 into MSYS2-packages. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Jul 8, 2024
Looks like we haven't updated `MSYS2-packages`' `msys2-runtime-3.4` directory in quite a while. This roll-up integrates: - msys2/msys2-runtime#205 - msys2/msys2-runtime#209 - msys2/msys2-runtime#210 - msys2/msys2-runtime#192 Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Jul 9, 2024
Looks like we haven't updated `MSYS2-packages`' `msys2-runtime-3.4` directory in quite a while. This roll-up integrates: - msys2/msys2-runtime#192 - msys2/msys2-runtime#205 - msys2/msys2-runtime#209 - msys2/msys2-runtime#210 - msys2/msys2-runtime#220 Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We backported it in #209 but there is a followup regression fix upstream which we should probably backport too: https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=56e7563b9aa665f35b657537e46a7feb4726f763