makepkg: strip breaks split debug info files

[jeremyd2019]

Steps to reproduce:

• install artifacts from nghttp2: Update to 1.63.0 MSYS2-packages#4858
• notice msys-2.0.dll.debug is only 18KB (not nearly large enough to have debug info)
• attempt to debug something

Expected results:
get debug symbols for msys-2.0.dll, like when they were in msys-2.0.dbg

Actual results:
warning: the debug information found in "/usr/bin/msys-2.0.dll.debug" does not match "/usr/bin/msys-2.0.dll" (CRC mismatch).

(gdb) bt
#0  0x00007ffcb22f7a7e in KERNELBASE!CtrlRoutine ()
   from /c/Windows/System32/KERNELBASE.dll
#1  0x0000000180045f63 in ?? () from /usr/bin/msys-2.0.dll
#2  0x0000000180046014 in ?? () from /usr/bin/msys-2.0.dll
#3  0x00007ffcb260257d in KERNEL32!BaseThreadInitThunk ()
   from /c/Windows/System32/KERNEL32.DLL
#4  0x00007ffcb488aa48 in ntdll!RtlUserThreadStart ()
   from /c/Windows/SYSTEM32/ntdll.dll
#5  0x0000000000000000 in ?? ()

$ objdump -W /usr/bin/msys-2.0.dll.debug
objdump: Warning: Separate debug info file /usr/bin/msys-2.0.dll.debug found, but CRC does not match - ignoring
objdump: Warning: could not find separate debug file 'msys-2.0.dll.debug'
objdump: Warning: tried: /lib/debug/msys-2.0.dll.debug
objdump: Warning: tried: /usr/lib/debug/usr/msys-2.0.dll.debug
objdump: Warning: tried: /usr/lib/debug//usr/bin//msys-2.0.dll.debug
objdump: Warning: tried: /usr/lib/debug/msys-2.0.dll.debug
objdump: Warning: tried: /usr/bin/.debug/msys-2.0.dll.debug
objdump: Warning: tried: /usr/bin/msys-2.0.dll.debug
objdump: Warning: tried: .debug/msys-2.0.dll.debug
objdump: Warning: tried: msys-2.0.dll.debug

/usr/bin/msys-2.0.dll.debug:     file format pei-x86-64

Contents of the .gnu_debuglink section:

  Separate debug info file: msys-2.0.dll.debug
  CRC value: 0xda4d40db

[jeremyd2019]

Compare to msys2-runtime-3.3{,-devel}, where msys-2.0.dbg is 20MB:

$ objdump -W /usr/bin/msys-2.0.dll | head
objdump
: Warning: /usr/bin/msys-2.0.dll: Found separate debug info file: /usr/bin/msys-2.0.dbg
could not find separate debug file 'null'
objdump: Warning: tried: /lib/debug/null
objdump: Warning: tried: /usr/lib/debug/usr/null
objdump: Warning: tried: /usr/lib/debug//usr/bin//null
objdump: Warning: tried: /usr/lib/debug/null
objdump: Warning: tried: /usr/bin/.debug/null
objdump: Warning: tried: /usr/bin/null
objdump: Warning: tried: .debug/null
objdump: Warning: tried: null
Contents of the .debug_aranges section (loaded from /usr/bin/msys-2.0.dbg):

  Length:                   44
  Version:                  2
  Offset into .debug_info:  0
  Pointer Size:             8
  Segment Size:             0

[jeremyd2019]

Was thinking about this, and testing confirmed it seems to be due to the logic that determines files to strip seeing the .debug files as binaries that need stripping, and therefore stripping them. Perhaps what needs to happen is the list of extensions to exclude on

msys2-pacman/scripts/libmakepkg/tidy/strip.sh.in

Line 125 in 761a878

-o -type f -executable ! -name '*.dll' ! -name '*.exe' ! -name '*.so' ! -name '*.so.[0-9]*' ! -name '*.oct' ! -name '*.cmxs' ! -name '*.a' ! -name '*.la' ! -name '*.lib' ! -name '*.exe.manifest' ! -name '*.exe.config' ! -name '*.dll.config' ! -name '*.mdb' ! -name '*-config' ! -name '*.csh' ! -name '*.sh' ! -name '*.pl' ! -name '*.pm' ! -name '*.py' ! -name '*.rb' ! -name '*.tcl' -print0 | \

should have *.debug (and maybe *.dbg if we want to keep the old name for msys-2.0.dbg) added to it?

Also, maybe

msys2-pacman/scripts/libmakepkg/tidy/strip.sh.in

Lines 176 to 184 in 761a878

	case "${binary##*/}" in
	*.dll|*.exe|*.sfx|*.so|*.so.[0-9]*|*.oct|*.cmxs) ;;
	# make sure this isn't some oddly named DLL
	*) if LANG=en_US.UTF-8 LC_ALL=C objdump -f "${binary}" | grep -Eq '^start address 0x(0000000[01])?00401[0-9a-e][0-9a-e]0'
	then
	mv "${binary}" "${binary}.exe"
	binary+=.exe
	fi ;;
	esac

is the reason for the whatever.exe.debug.exe files that shouldn't have been there? (I think if *.debug were excluded in the find they would go away too, rather than having to add *.debug to the case statement above to exclude them here)

[lazka]

just checking, do you think this is a regression from the recent update/rebase or has always been the case?

[jeremyd2019]

I think this has "always" been the case (the code looks the same on the 5.2.2 branch, anyway)

[jeremyd2019]

This may just be an artifact of my attempt to "cheat" with msys2-runtime and not enable the debug option at the top-level of the PKGBUILD. It looks like create_debug_package() in makepkg.sh.in calls create_package, which is called after tidy_install in the normal packaging path. (so normally the automatically-generated debug package would not be tidied or linted)