Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-assets: delete realease in case all assets need to be deleted #77

Closed
lazka opened this issue Jul 29, 2023 · 3 comments · Fixed by #78
Closed

clean-assets: delete realease in case all assets need to be deleted #77

lazka opened this issue Jul 29, 2023 · 3 comments · Fixed by #78

Comments

@lazka
Copy link
Member

lazka commented Jul 29, 2023

For this Python rebuild we had >5000 files and requires manual fixing when we need to clean things up because we would hit the api limit 5 times.

In case every asset of a release is about to be deleted we could just delete the whole release instead.
@jeremyd2019
Copy link
Member

There were "only" about 820 files for clangarm64, it was able to delete them all in one go.

@lazka lazka changed the title delete-assets: delete realease in case all assets need to be deleted clean-assets: delete realease in case all assets need to be deleted Jul 30, 2023
lazka added a commit to lazka/msys2-autobuild that referenced this issue Jul 30, 2023
@lazka
clean-assets: delete realease in case all assets need to be deleted
e23a4db 
In case a release has hundreds of files that need to be deleted this
requires quite a bit of time and also works against the API rate limiting.

In case we want to delete all assets of an release just delete and
re-create the whole release instead.

Fixes msys2#77
@lazka lazka mentioned this issue Jul 30, 2023
Merged
lazka added a commit to lazka/msys2-autobuild that referenced this issue Jul 30, 2023
@lazka
clean-assets: delete release in case all assets need to be deleted
6b4a7e2 
In case a release has hundreds of files that need to be deleted this
requires quite a bit of time and also works against the API rate limiting.

In case we want to delete all assets of an release just delete and
re-create the whole release instead.

Fixes msys2#77
@lazka lazka closed this as completed in #78 Jul 30, 2023
lazka added a commit that referenced this issue Jul 30, 2023
@lazka
clean-assets: delete release in case all assets need to be deleted
4db4e22 
In case a release has hundreds of files that need to be deleted this
requires quite a bit of time and also works against the API rate limiting.

In case we want to delete all assets of an release just delete and
re-create the whole release instead.

Fixes #77
@jeremyd2019
Copy link
Member

One thing to be aware of is that deleting and re-creating releases results in github sending notifications. I may unsubscribe from release notifications specifically if this happens very often...

@lazka
Copy link
Member Author

lazka commented Jul 30, 2023

oh, good point

@lazka lazka reopened this Jul 30, 2023
@lazka lazka closed this as completed in 1f1faba Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean-assets: delete release in case all assets need to be deleted lazka/msys2-autobuild
2 participants
@lazka @jeremyd2019