Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: update to 1.81.0 #21847

Merged
merged 1 commit into from
Sep 6, 2024
Merged

rust: update to 1.81.0 #21847

merged 1 commit into from
Sep 6, 2024

Conversation

ognevny
Copy link
Collaborator

@ognevny ognevny commented Sep 4, 2024

  • disable self-contained for *-windows-gnu* targets only
  • fix license installation for rust-wasm and rust-src packages

@ognevny ognevny force-pushed the update-rust branch 2 times, most recently from c92fb19 to a8e3c2d Compare September 4, 2024 11:04
@ognevny
Copy link
Collaborator Author

ognevny commented Sep 4, 2024

@mati865 what blocks us for switching to *-gnullvm targets for clang envs?

@ognevny
Copy link
Collaborator Author

ognevny commented Sep 4, 2024

fails with:

thread 'main' panicked at src/lib.rs:1742:13:
dst_file.set_times(file_times) failed with Access is denied. (os error 5)
stack backtrace:
   0: rust_begin_unwind
             at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library\std\src/panicking.rs:652:5
   1: core::panicking::panic_fmt
             at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library\core\src/panicking.rs:72:14
   2: bootstrap::Build::copy_link_internal
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\utils\helpers.rs:40:23
   3: bootstrap::Build::copy_link
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\lib.rs:1697:9
   4: bootstrap::core::build_steps::compile::copy_self_contained_objects
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\compile.rs:419:13
   5: bootstrap::core::build_steps::compile::Std::copy_extra_objects
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\compile.rs:110:25
   6: <bootstrap::core::build_steps::compile::Std as bootstrap::core::builder::Step>::run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\compile.rs:218:28
   7: bootstrap::core::builder::Builder::ensure
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:2249:23
   8: <bootstrap::core::build_steps::compile::Rustc as bootstrap::core::builder::Step>::run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\compile.rs:874:9
   9: bootstrap::core::builder::Builder::ensure
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:2249:23
  10: <bootstrap::core::build_steps::compile::Assemble as bootstrap::core::builder::Step>::run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\compile.rs:1735:28
  11: bootstrap::core::builder::Builder::ensure
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:2249:23
  12: bootstrap::core::builder::Builder::compiler
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:1106:9
  13: <bootstrap::core::build_steps::compile::Assemble as bootstrap::core::builder::Step>::run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\compile.rs:1728:34
  14: bootstrap::core::builder::Builder::ensure
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:2249:23
  15: bootstrap::core::builder::Builder::compiler
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:1106:9
  16: <bootstrap::core::build_steps::install::Std as bootstrap::core::builder::Step>::make_run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\build_steps\install.rs:188:31
  17: bootstrap::core::builder::StepDescription::maybe_run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:392:13
  18: bootstrap::core::builder::StepDescription::run
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:433:21
  19: bootstrap::core::builder::Builder::run_step_descriptions
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:1098:9
  20: bootstrap::core::builder::Builder::execute_cli
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\core\builder.rs:1078:9
  21: bootstrap::Build::build
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src\lib.rs:667:13
  22: bootstrap::main
             at C:\_\B\src\rustc-1.81.0-src\src\bootstrap\src/bin\main.rs:79:5
  23: core::ops::function::FnOnce::call_once
             at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23\library\core\src\ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@mati865
Copy link
Collaborator

mati865 commented Sep 4, 2024

@mati865 what blocks us for switching to *-gnullvm targets for clang envs?

I don't think there is anything that blocks us, I think I've said that in one of the recent PRs/issues/some kind of discussions.

EDIT: gnullvm targets are unaffected by the error above but it has to be solved either way.

@ognevny
Copy link
Collaborator Author

ognevny commented Sep 4, 2024

EDIT: gnullvm targets are unaffected by the error above but it has to be solved either way.

so what's wrong? why bootstrap throw such thing?

@mati865
Copy link
Collaborator

mati865 commented Sep 4, 2024

It looks like backporting rust-lang/rust#128977 is necessary due to Windows weirdness.

@ognevny
Copy link
Collaborator Author

ognevny commented Sep 4, 2024

It looks like backporting rust-lang/rust#128977 is necessary due to Windows weirdness.

thanks, I'll backport it after official release

@ognevny
Copy link
Collaborator Author

ognevny commented Sep 5, 2024

thanks, I'll backport it after official release

they've pushed 1.80.1 release on github instead of 1.81.0 🤦

update: it will be a bit later, and 1.80.1 appeared late because release notes were missing at master branch

@mati865
Copy link
Collaborator

mati865 commented Sep 5, 2024

they've pushed 1.80.1 release on github instead of 1.81.0 🤦

1.80.1 is a different release with a bugfix, 1.81 will be released later today.

@filnet
Copy link
Contributor

filnet commented Sep 5, 2024

Official 1.81.0 is out: https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html

@ognevny
Copy link
Collaborator Author

ognevny commented Sep 5, 2024

say hi to some unwanted binaries!

  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/
  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/gcc-ld/
  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/gcc-ld/ld.lld.exe
  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/gcc-ld/ld64.lld.exe
  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/gcc-ld/lld-link.exe
  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/gcc-ld/wasm-ld.exe
  +/ucrt64/lib/rustlib/x86_64-pc-windows-gnu/bin/rust-lld.exe

@ognevny ognevny force-pushed the update-rust branch 4 times, most recently from 238ea25 to 9d1523f Compare September 6, 2024 05:40
@ognevny ognevny marked this pull request as ready for review September 6, 2024 07:43
@ognevny ognevny merged commit 4b6e477 into msys2:master Sep 6, 2024
8 checks passed
@ognevny ognevny deleted the update-rust branch September 6, 2024 09:56
@ognevny
Copy link
Collaborator Author

ognevny commented Sep 7, 2024

I don't think there is anything that blocks us, I think I've said that in one of the recent PRs/issues/some kind of discussions.

forgot to write here: you can open a PR, why not?

@mati865
Copy link
Collaborator

mati865 commented Sep 11, 2024

Due to lack of time. To not prolong it even more, I've stopped trying with _bootstrapping=yes and took a shortcut: #21902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants