Fix lxml crashing #19598
Merged
Fix lxml crashing #19598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the build options forcing cythin to run were no longer passed to setup.py which meant the cython patch preventing a crash was no longer included in the compiled C code, which re-surfaced crashes in the meson test sutei for example.
|
Yay, and of course the terrible setuptools PEP517 build layer just says nothing whatsoever about this when you get it wrong? |
|
Yeah, I think it just ignores unknown options. edit: maybe something which should be reported with setuptools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the build options forcing cython to run were no longer passed to setup.py which meant the cython patch preventing a crash was no longer included in the compiled C code, which re-surfaced crashes in the meson test suite for example.