add flash on successful workflow dispatch #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what I was thinking about for #12 but never got around to.
|
lgtm |
|
The reason I didn't do these previously is that I have not tested them. It was kind of a hassle to log into pythonanywhere with the 2 factor auth, and these changes were not worth the trouble, I was waiting for some more substantive change that never came. |
|
Was thinking it might make sense to add a different "failed" message in an |
|
Agreed on the error case (part of #15 I guess), but let's just get this in for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I was thinking about to resolve #12 but never got around to.