fix: update @inquirer/confirm to 4.0
#2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
@inquirer/confirm to 4.0
|
Hi, @greysteil 👋 Thanks for submitting this. I think this looks great. |
kettanaito
approved these changes
Oct 21, 2024
kettanaito
changed the title
@inquirer/confirm to 4.0@inquirer/confirm to 4.0
|
Publishing it as a fix. No user-facing changes present. |
Released: v2.4.13 🎉This has been released in v2.4.13! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
|
It looks like we still need one more bump to |
|
@ravicious sounds good. Pull requests are welcome! |
|
All yours @ravicious (or I'll take it if you're busy) |
|
I have to yield as I don't have enough free time at work to take care of this, but I do appreciate your effort! |
|
Done in #2325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change between v3 and v4 is allowing the prefix for the confirm message to be changed, which msw doesn't use. (Alternatively we could widen the supported range here to
^3.0.0 || ^4.0.0, but it looks like msw generally specifies a single major version it supports.)The main benefit of the change will be to get access to SBoudrias/Inquirer.js#1569 once it lands (or to make it easier to do so if that is released in a new major version). That will reduce development build size for lots of apps which are currently getting two versions of
@types/nodedue to this dependency.