fix: support native URLSearchParams
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comatory
approved these changes
Oct 21, 2024
jiri-prokop-pb
force-pushed
the
fix-url-search-params
branch
from
41f0e80
to
2003516
Compare
jiri-prokop-pb
force-pushed
the
fix-url-search-params
branch
from
2003516
to
e44ba0e
Compare
Released: v0.0.6 🎉This has been released in v0.0.6! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating to MSW v2 we had strange, seemingly unrelated, failure in one of our tests.
After some debugging it turned out it's related to
jest-fixed-domreplacingURLwith native one. I don't know why exactly it's broken but I provided a test and you can check this on your own, if you are interested.Basically, if you mock methods on
URLSearchParamsand then you access it throughURL.searchParams, the mock won't work. By just simply addingthis.global.URLSearchParams = URLSearchParamsit will start working.