fix: support Readable as request body #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Mar 21, 2024
•
kettanaito
commented
- Closes fix: support Readable as the request body #522
kettanaito
commented
Mar 21, 2024
| @@ -34,7 +34,7 @@ export class MockSocket extends net.Socket { | |||
| public write(...args: Array<unknown>): boolean { | |||
| const [chunk, encoding, callback] = normalizeWriteArgs(args as WriteArgs) | |||
| this.options.write(chunk, encoding, callback) | |||
| return false | |||
| return true | |||
There was a problem hiding this comment.
@mikicho, let's return true.
kettanaito
force-pushed
the
fix/readable-request-body
branch
from
8503ed7
to
78ba640
Compare
|
Resolved the tests, let's merge this! |
kettanaito
merged commit 2b1a5d7
into
feat/yet-another-socket-interceptor
1 check passed
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.