fix(WebSocket): make MessageEvent cancelable #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Feb 15, 2024
kettanaito
commented
- See MessageEvent cannot be prevented even if cancelable is true nodejs/node#51767
kettanaito
commented
Feb 15, 2024
| "undici": "^6.5.0", | ||
| "vitest": "^0.28.5", | ||
| "undici": "^6.6.2", | ||
| "vitest": "^1.2.2", |
There was a problem hiding this comment.
Updating vitest has broke a few tests that were using .toContain() for partial object assertions. The behavior of that matcher seemed to have changed across Vitest releases.
I've changed the tests to use .toMatchObject().
kettanaito
commented
Feb 15, 2024
| * | ||
| * @see https://github.com/nodejs/node/issues/51767 | ||
| */ | ||
| export class CancelableMessageEvent<T = any> extends MessageEvent<T> { |
There was a problem hiding this comment.
This is something we need to remove in the future.
TL;DR Node's MessageEvent cannot be canceled. Doesn't respect the cancelable attribute and so preventDefault() does nothing. Looks like a bug in Node.js. Reported.
Released: v0.26.2 🎉This has been released in v0.26.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.