4789 item variant UI pt2 #5227
4789 item variant UI pt2 #5227
Conversation
github-actions
bot
added
enhancement
| }, | ||
| { | ||
| key: 'name', | ||
| Cell: update ? TextInputCell : TooltipTextCell, |
There was a problem hiding this comment.
thoughts on logic here to be able to reuse the table component?
| fullWidth | ||
| /> | ||
| } | ||
| Input={<BasicTextInput value={variant.name} disabled fullWidth />} |
There was a problem hiding this comment.
Could have reused the edit form from the modal here, but am under the impression that item variants are likely to end up with a lot of fields, and probably only want a subset in the tab view 👀
There was a problem hiding this comment.
Really? I would have thought we'd want to see the same fields on the tab view as in the modal. How many are we talking?
There was a problem hiding this comment.
I think we're talking long term, but that's what Adam has said 😁 I think I'll stick with it anyway - nice not to do things like query all manufacturers for the dropdown, only to display read only data
client/packages/system/src/Item/api/hooks/useItemVariant/useItemVariant.ts
Outdated
Show resolved
Hide resolved
Bundle size differenceComparing this PR to
|
| }, | ||
| { | ||
| key: 'name', | ||
| Cell: update ? TextInputCell : TooltipTextCell, |
| fullWidth | ||
| /> | ||
| } | ||
| Input={<BasicTextInput value={variant.name} disabled fullWidth />} |
There was a problem hiding this comment.
Really? I would have thought we'd want to see the same fields on the tab view as in the modal. How many are we talking?
Fixes #4789
👩🏻💻 What does this PR do?
Moves add/edit of item variants to modal:
💌 Any notes for the reviewer?
🧪 Testing
📃 Documentation
1.
2.