-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4789 item variant UI pt2 #5227
4789 item variant UI pt2 #5227
Conversation
}, | ||
{ | ||
key: 'name', | ||
Cell: update ? TextInputCell : TooltipTextCell, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on logic here to be able to reuse the table component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good ππΌ
fullWidth | ||
/> | ||
} | ||
Input={<BasicTextInput value={variant.name} disabled fullWidth />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have reused the edit form from the modal here, but am under the impression that item variants are likely to end up with a lot of fields, and probably only want a subset in the tab view π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? I would have thought we'd want to see the same fields on the tab view as in the modal. How many are we talking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're talking long term, but that's what Adam has said π I think I'll stick with it anyway - nice not to do things like query all manufacturers for the dropdown, only to display read only data
client/packages/system/src/Item/api/hooks/useItemVariant/useItemVariant.ts
Outdated
Show resolved
Hide resolved
Bundle size differenceComparing this PR to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, allowing for the TO-DOs and the other considerations we discussed IRL.
Maybe just chuck in the empty array when no variants defined, and add the "No data" component as discussed?
}, | ||
{ | ||
key: 'name', | ||
Cell: update ? TextInputCell : TooltipTextCell, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good ππΌ
fullWidth | ||
/> | ||
} | ||
Input={<BasicTextInput value={variant.name} disabled fullWidth />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? I would have thought we'd want to see the same fields on the tab view as in the modal. How many are we talking?
Fixes #4789
π©π»βπ» What does this PR do?
Moves add/edit of item variants to modal:
π Any notes for the reviewer?
π§ͺ Testing
π Documentation
1.
2.