Fail writes with ChannelOutputShutdownException when STREAM_STOPPED i… (

java-native-access#683)

…s received

Motivation:

If STREAM_STOPPED is received we should fail all writes with
ChannelOutputShutdownException before tearing down the channel

Modifications:

Explicit handle STREAM_STOPPED

Result:

Better signaling of received STREAM_STOPPED

codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicheQuicChannel.java

@@ -1063,7 +1063,7 @@ private boolean handleWritableStreams(QuicheQuicConnection conn) {
                                 int capacity = Quiche.quiche_conn_stream_capacity(connAddr, streamId);
                                 if (capacity < 0) {
                                     // Let's close the channel if quiche_conn_stream_capacity(...) returns an error.
-                                    streamChannel.forceClose();
+                                    streamChannel.forceClose(capacity);
                                 } else if (streamChannel.writable(capacity)) {
                                     mayNeedWrite = true;
                                 }

codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicheQuicStreamChannel.java

@@ -410,6 +410,18 @@ private void updateWritabilityIfNeeded(boolean newWritable) {
         }
     }
 
+    void forceClose(int error) {
+        if (!queue.isEmpty()) {
+            QuicException err = new QuicException(QuicError.valueOf(error));
+            if (error == QuicError.STREAM_STOPPED.code()) {
+                queue.removeAndFailAll(new ChannelOutputShutdownException("STREAM_STOPPED received", err));
+            } else {
+                queue.removeAndFailAll(err);
+            }
+        }
+        forceClose();
+    }
+
     /**
      * Stream is readable.
      */
@@ -646,7 +658,9 @@ boolean writeQueued() {
                         if (e instanceof QuicException && (
                                 (QuicException) e).error() == QuicError.STREAM_STOPPED) {
                             // Once its signaled that the stream is stopped we can just fail everything.
-                            queue.removeAndFailAll(e);
+                            // We can also force the close as quiche will generate a RESET_STREAM frame.
+                            queue.removeAndFailAll(
+                                    new ChannelOutputShutdownException("STREAM_STOPPED received", e));
                             forceClose();
                             break;
                         }