Skip to content

Commit

Permalink
Remove QuicStreamChannel.WRITE_FIN (java-native-access#620)
Browse files Browse the repository at this point in the history
Motivation:

QuicStreamChannel.WRITE_FIN was deprecated a long time ago. Let's remove
it as this release will contain another breaking change anyway.

Modifications:

Remove QuicStreamChannel.WRITE_FIN

Result:

Cleanup
  • Loading branch information
normanmaurer authored Nov 22, 2023
1 parent 2d2d488 commit a59908a
Showing 1 changed file with 1 addition and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,11 @@
*/
public interface QuicStreamChannel extends DuplexChannel {

/**
* Should be added to a {@link ChannelFuture} when the {@code FIN} should be sent to the remote peer and no more
* writes will happen.
*
* <strong>Important:</strong> The FIN will not be propagated through the {@link io.netty.channel.ChannelPipeline}
* to make it easier to reuse this {@link ChannelFutureListener} with all kind of different handlers that sit on top
* of {@code QUIC}. If you want to ensure the {@code FIN} is propagated through the
* {@link io.netty.channel.ChannelPipeline} as a write just write a {@link QuicStreamFrame} directly with the
* {@code FIN} set.
*
* @deprecated use {@link #SHUTDOWN_OUTPUT}
*/
@Deprecated
ChannelFutureListener WRITE_FIN = f -> ((QuicStreamChannel) f.channel()).shutdownOutput();

/**
* Should be added to a {@link ChannelFuture} when the output should be cleanly shutdown via a {@code FIN}. No more
* writes will be allowed after this point.
*/
ChannelFutureListener SHUTDOWN_OUTPUT = WRITE_FIN;
ChannelFutureListener SHUTDOWN_OUTPUT = f -> ((QuicStreamChannel) f.channel()).shutdownOutput();

@Override
default ChannelFuture bind(SocketAddress socketAddress) {
Expand Down

0 comments on commit a59908a

Please sign in to comment.