Skip to content

Commit

Permalink
Set the number of streams to a value low enough to not deadlock becau…
Browse files Browse the repository at this point in the history
…se of the window (java-native-access#469)

Motivation:

We used a value of 1024 which was too big if we couldnt schedule the reads / writes in the right timely manner. This could lead to a deadlock.

Modifications:

Use a lower value which still provide the required testing but not put us in risk of deadlocks during tests

Result:

More stable builds on CI
  • Loading branch information
normanmaurer authored Jan 20, 2023
1 parent 2527e11 commit 9383600
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class QuicReadableTest extends AbstractQuicTest {
@ParameterizedTest
@MethodSource("sslTaskExecutors")
public void testCorrectlyHandleReadableStreams(Executor executor) throws Throwable {
int numOfStreams = 1024;
int numOfStreams = 256;
int readStreams = numOfStreams / 2;
// We do write longs.
int expectedDataRead = readStreams * Long.BYTES;
Expand Down

0 comments on commit 9383600

Please sign in to comment.