Skip to content

Commit

Permalink
Github Actions dawidd6/action-download-artifact set workflow_conclusi…
Browse files Browse the repository at this point in the history
…on and upgrade (java-native-access#225)

Motivation:

Newer versions of dawidd6/action-download-artifact changed the default
workflow_conclusion from "completed" to "completed, success" which can
result in download failures if the associated job fails, which is
expected when tests fail.

Modifications:

- Explicitly set the workflow_conclusion to "completed"
- Update to new version

Result:

Test failures which result in build failures will still download test
data and generate reports after updating dawidd6/action-download-artifact.
  • Loading branch information
normanmaurer authored Mar 19, 2021
1 parent e1d5e4c commit 12e446b
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci-pr-reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Download Artifacts
uses: dawidd6/action-download-artifact@v2.11.0
uses: dawidd6/action-download-artifact@v2.13.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: completed
commit: ${{ github.event.workflow_run.head_commit.id }}
# File location set in ci-pr.yml and must be coordinated.
name: test-results-pr-linux-x86_64
Expand All @@ -28,10 +29,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Download Artifacts
uses: dawidd6/action-download-artifact@v2.11.0
uses: dawidd6/action-download-artifact@v2.13.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: completed
commit: ${{ github.event.workflow_run.head_commit.id }}
# File location set in ci-pr.yml and must be coordinated.
name: test-results-pr-windows-x86_64
Expand Down

0 comments on commit 12e446b

Please sign in to comment.