-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #409
Merged
Merged
Updates #409
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0743846
ImageCleaner GA (no longer preview)
skabou cc5c1ee
mcr image with curl
skabou edebe27
mcr image with curl
skabou cd4a214
Merge branch 'main' of https://github.com/skabou/aks-baseline
skabou a836d43
Merge branch 'main' of https://github.com/skabou/aks-baseline
skabou dada7d3
Delete aspnetapp-ingress-patch.yaml
skabou 7bba6a3
Merge branch 'main' of https://github.com/skabou/aks-baseline
skabou 3567e16
Delete nested_K8sCustomIngressTlsHostsHaveDefinedDomainSuffix.bicep
skabou 0e5f541
Merge branch 'main' of https://github.com/skabou/aks-baseline
skabou 6dab026
restore nested_K8s...
skabou 1e34410
Update nested_K8sCustomIngressTlsHostsHaveDefinedDomainSuffix.bicep
skabou 4ed7a7e
Delete .gitignore
skabou 8b017f0
restore .gitignore
skabou 9a5e183
restore .gitignore
skabou 7bd8110
correction
skabou ebc9e71
Revert "correction"
skabou 6f1acb1
Revert "restore .gitignore"
skabou 83aeb40
Revert "Delete .gitignore"
skabou 62ac51c
Revert "Update nested_K8sCustomIngressTlsHostsHaveDefinedDomainSuffix…
skabou 56e6705
Revert "restore nested_K8s..."
skabou 6aea1a3
Revert "Merge branch 'main' of https://github.com/skabou/aks-baseline"
skabou 24fbe48
Restore nested_K8sCustomIngressTlsHostsHaveDefinedDomainSuffix.bicep
skabou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ Finally, this implementation uses the [ASP.NET Core Docker sample web app](https | |
|
||
#### Azure platform | ||
|
||
- AKS v1.28 | ||
- AKS v1.29 | ||
- System and User [node pool separation](https://learn.microsoft.com/azure/aks/use-system-pools) | ||
- [AKS-managed Microsoft Entra ID integration](https://learn.microsoft.com/azure/aks/managed-aad) | ||
- Microsoft Entra ID-backed Kubernetes RBAC (*local user accounts disabled*) | ||
|
@@ -43,7 +43,7 @@ Finally, this implementation uses the [ASP.NET Core Docker sample web app](https | |
- [ImageCleaner (Eraser)](https://learn.microsoft.com/azure/aks/image-cleaner) *[AKS-managed add-on]* | ||
- [Kubernetes Reboot Daemon](https://learn.microsoft.com/azure/aks/node-updates-kured) | ||
- [Secrets Store CSI Driver for Kubernetes](https://learn.microsoft.com/azure/aks/csi-secrets-store-driver) *[AKS-managed add-on]* | ||
- [Traefik Ingress Controller](https://doc.traefik.io/traefik/v2.10/routing/providers/kubernetes-ingress/) | ||
- [Traefik Ingress Controller](https://doc.traefik.io/traefik/v2.11/routing/providers/kubernetes-ingress/) | ||
|
||
![Network diagram depicting a hub-spoke network with two peered VNets and main Azure resources used in the architecture.](https://learn.microsoft.com/azure/architecture/reference-architectures/containers/aks/images/secure-baseline-architecture.svg) | ||
|
||
|
@@ -152,4 +152,4 @@ Please see our [Contributor guide](./CONTRIBUTING.md). | |
|
||
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact <[email protected]> with any additional questions or comments. | ||
|
||
With :heart: from Microsoft Patterns & Practices, [Azure Architecture Center](https://aka.ms/architecture). | ||
With :heart: from Microsoft Patterns & Practices, [Azure Architecture Center](https://aka.ms/architecture). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,4 +128,4 @@ spec: | |
name: aspnetapp-service | ||
port: | ||
number: 80 | ||
--- | ||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we maintaining the client version n-1 for a reason? Any desire to move over 1.29 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the guidance I received from @ckittel on a previous PR.
Also, it appears to be official policy from Kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, while Im aware of how it gets supported, I was wondering why we are prescribing that. Just wanted to learn from this.