Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SecretProviderClass API version #323

Merged
merged 1 commit into from
May 26, 2022
Merged

Update SecretProviderClass API version #323

merged 1 commit into from
May 26, 2022

Conversation

ckittel
Copy link
Member

@ckittel ckittel commented May 25, 2022 •
edited
Loading

  • Updates the inline SecretProviderClass to use the GA API version
  • Adds explicit false for useVMManagedIdentity

@ckittel ckittel requested a review from ferantivero May 25, 2022 14:17
@ckittel ckittel self-assigned this May 25, 2022
@hallihan hallihan self-requested a review May 25, 2022 18:04
ferantivero
ferantivero approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@ferantivero ferantivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t nicely done @ckittel LGTM :shipit:

@ckittel ckittel merged commit ed6277f into main May 26, 2022
@ckittel ckittel deleted the ckittel-patch-1 branch May 26, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferantivero ferantivero ferantivero approved these changes

@hallihan hallihan Awaiting requested review from hallihan

Assignees

@ckittel ckittel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckittel @ferantivero