Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes & usability improvements #305

Merged
merged 8 commits into from
Apr 28, 2022
Merged

Minor fixes & usability improvements #305

merged 8 commits into from
Apr 28, 2022

Conversation

ulkeba
Copy link
Contributor

@ulkeba ulkeba commented Apr 28, 2022

  • Some regions (e.g., also East US 2) require udp/1194 for master to node communication.
  • spoke-BU0001A0008.bicep needs to return the IP rather than the Public IP resource ID.
  • As minimal user feedback, echo variables to console after setting.

ckittel
ckittel requested changes Apr 28, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

We had originally avoided the echo statements, but we've had multiple requests for them -- so I'm all for trying them out and seeing if we get any feedback one way or the other. Thanks.

Other feedback below.

networking/hub-regionA.bicep Outdated Show resolved Hide resolved
networking/hub-regionA.bicep Outdated Show resolved Hide resolved
networking/spoke-BU0001A0008.bicep Show resolved Hide resolved
ckittel
ckittel requested changes Apr 28, 2022
View reviewed changes
04-networking.md Outdated Show resolved Hide resolved
ckittel
ckittel approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪

@ckittel ckittel merged commit 0fea5e5 into mspnp:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckittel ckittel ckittel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulkeba @ckittel