feat (templates): [cluster] migrate to bicep #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entity highlights: - resource group: networking - spoke - assign roles at the spoke ingress and cluster nodes subnets level
… at the subscription level highlights: - resource group: aks cluster
ferantivero
force-pushed
the
feature/571187_bicep_cluster-stamp
branch
from
44eebd5
to
7a075c7
Compare
ferantivero
force-pushed
the
feature/571187_bicep_cluster-stamp
branch
from
7a075c7
to
0f9bfd0
Compare
ferantivero
changed the title
…s and other minors
This reverts commit a1d83e8.
ferantivero
force-pushed
the
feature/571187_bicep_cluster-stamp
branch
from
f8b2d8b
to
6610084
Compare
|
w00t @ckittel current version is working. |
ckittel
reviewed
Apr 28, 2022
|
Nice work! Just one more small observation ^, and this can be merged. |
ckittel
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
LGTM, given the above feedback, @ferantivero. Okay to merge? If so, can you update the PR body with any "additional changes" made (like general API version updates)
|
Great job, @ferantivero & @ckittel. Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #571187
WHY
we wanted to move our last ARM json template (cluster-stamp) to bicep, so we fully support this lang for deploying from the AKS Baseline.
What Changed?
Ensuredeploymentsexistingresources.HOW to Test?
You should be able to follow the instructions and successfully deploy an AKS Baseline cluster having a full bicep experience along the road.