This repository has been archived by the owner on Aug 7, 2018. It is now read-only.
Allow updating height and color options through props #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
force-pushed
the
update-height-and-color
branch
from
1ff41c5 to
3a65560
Compare
Use Wavesurfer setter methods to update `waveColor`, `progressColor`, `cursorColor` and `height` if the value changed inside the `options` prop.
tf
force-pushed
the
update-height-and-color
branch
from
3a65560 to
68a804a
Compare
|
The PR on wavesutfer.js has been merged. Not sure if this is blocked until a version containing the changes has been released. Otherwise it might be worth creating a |
tf
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Wavesurfer setter methods to update
waveColor,progressColor,cursorColorand
heightif the value changed inside theoptionsprop.Requires katspaugh/wavesurfer.js#1145 to be merged/released first.