Fixing a bug where the CPLEX check was forcefully implemented even when using Gurobi #96
Conversation
R/JaBbA.R
Outdated
| @@ -55,13 +55,28 @@ low.count=high.count=seg=chromosome=alpha_high=alpha_low=beta_high=beta_low=pred | |||
| jmessage("${CPLEX_DIR}/cplex/[(include)|(lib)] do not both exist") | |||
| } | |||
|
|
|||
| if (!requireNamespace("gurobi", quietly = TRUE)) { | |||
| jmessage("Gurobi is not installed! REMEMBER: You need to have either CPLEX or Gurobi!") | |||
| if (((!file.exists(paste0(cplex.dir, "/cplex"))) & (!file.exists(paste0(cplex.dir, "/cplex/include")) || | |||
There was a problem hiding this comment.
Might be good to store these booleans into variables with informative names (e.g cplex_exists, gurobi_exists etc.). This is will make these conditionals much easier to read and reduce clutter (since you're repeating this code several times for subsequent conditionals).
There was a problem hiding this comment.
Ok done! I have updated my JaBbA td_dev.
There was a problem hiding this comment.
Much better! Please change _installation to _installed (you should try to approach natural english as much as you can when making these kinds of readability changes--if gurobi_installed sounds more natural than if gurobi_installation). Also remove the explanatory comments. Comments should really only be used to explain why you did something, not what you did. Let code itself show what you did.
Also use git commit --amend to avoid adding a new commit.
|
Done! |
Description:
Changes:
Impact: