Skip to content

Commit

Permalink
Merge pull request cockroachdb#105759 from cockroachdb/blathers/backp…
Browse files Browse the repository at this point in the history
…ort-release-22.2-105745

release-22.2: sql/importer: remove unused skip.WithIssue from TestImportData
  • Loading branch information
michae2 authored Jun 28, 2023
2 parents ab0a84e + 51adaaa commit 552ade7
Showing 1 changed file with 8 additions and 13 deletions.
21 changes: 8 additions & 13 deletions pkg/sql/importer/import_stmt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,14 @@ ORDER BY table_name
sqlDB.Exec(t, `SET CLUSTER SETTING storage.mvcc.range_tombstones.enabled = true`)

tests := []struct {
name string
create string
with string
typ string
data string
err string
rejected string
query map[string][][]string
skipIssue int
name string
create string
with string
typ string
data string
err string
rejected string
query map[string][][]string
}{
{
name: "duplicate unique index key",
Expand Down Expand Up @@ -1322,10 +1321,6 @@ COPY public.t (a, b) FROM stdin;
}
}
t.Run(fmt.Sprintf("%s/%s: save_rejected=%v", tc.typ, tc.name, saveRejected), func(t *testing.T) {
if tc.skipIssue != 0 {
skip.WithIssue(t, tc.skipIssue)
return
}
dbName := fmt.Sprintf("d%d", i)
if saveRejected {
dbName = dbName + "_save"
Expand Down

0 comments on commit 552ade7

Please sign in to comment.