Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
95555: build: update ci tests bench script to use iterations r=rickystewart a=herkolategan

The goal of the `bench_impl.sh` script is to confirm microbenchmarks can run for at least 1 iteration successfully. Hence we can change the `test.benchtime` flag from a duration of `1ns` to rather use the iteration notation `1x` and run for 1 iteration.

Epic: CRDB-20903

Release note: None

Co-authored-by: Herko Lategan <[email protected]>
  • Loading branch information
craig[bot] and herkolategan committed Jan 24, 2023
2 parents efd23f5 + bfcd709 commit 38d88c8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/teamcity/cockroach/ci/tests/bench_impl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ do
# We need the `test_sharding_strategy` flag or else the benchmarks will
# fail to run sharded tests like //pkg/sql/importer:importer_test.
bazel run --config=test --config=$CROSSLINUX_CONFIG --config=ci --test_sharding_strategy=disabled $target -- \
-test.bench=. -test.benchtime=1ns -test.short -test.run=-
-test.bench=. -test.benchtime=1x -test.short -test.run=-
tc_end_block "Bench $target"
done

0 comments on commit 38d88c8

Please sign in to comment.