Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subclass TinyDB from Table to make default table work with static typing #374

Closed
wants to merge 2 commits into from
Closed

Subclass TinyDB from Table to make default table work with static typing #374

wants to merge 2 commits into from

Conversation

corneliusroemer
Copy link

Fixes #372

@corneliusroemer
Copy link
Author

CI seems to use the old tests, I added a few new ones. How can they be added to the pipeline? Is this automatic once this is merged into master?

@msiemens
Copy link
Owner

msiemens commented Mar 1, 2021

Thanks for the Pull Request, @corneliusroemer! I'll try to review it in the next couple of days.

CI seems to use the old tests, I added a few new ones. How can they be added to the pipeline? Is this automatic once this is merged into master?

Actually the new tests should already be executed. I can't explain why they don't run either…

@msiemens
Copy link
Owner

@corneliusroemer I still haven't forgotten this PR, I hope to get around thinking this through to the end in time for the next release of TinyDB which I plan for the next week of the week after.

@msiemens msiemens mentioned this pull request Jun 17, 2021
Closed
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reopen this if needed. Thank you for your contributions ❤️

@stale stale bot added the stale label Jun 26, 2021
@msiemens
Copy link
Owner

Superseeded by 3c34154 which has been released in TinyDB 4.5.0

@msiemens msiemens closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No 'intellisense' autosuggestion of functions
2 participants
@corneliusroemer @msiemens