Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cimport uint64_t instead of using ctypedef #473

Merged
merged 1 commit into from
Mar 18, 2021
Merged

cimport uint64_t instead of using ctypedef #473

merged 1 commit into from
Mar 18, 2021

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Mar 18, 2021

Cython already has its out internal definition of uint64_t so it might as well be used here. In addition ctypedef causes a build break if msgpack is compiled with Cython3.

@methane methane merged commit 38dba96 into msgpack:main Mar 18, 2021
@methane
Copy link
Member

methane commented Mar 18, 2021

thank you.

@adrianeboyd adrianeboyd mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladima @methane