Msgpack serialize/unserialize support for APCu #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 87.19% 86.95% -0.25%
==========================================
Files 8 8
Lines 1234 1234
==========================================
- Hits 1076 1073 -3
- Misses 158 161 +3
Continue to review full report at Codecov.
|
It looks like apu is not loaded when tests run |
|
Other failed tests are not compatible with PHP 7 #109 |
|
Hi! Thanks for this submission. Please rebase this PR, so we can have a closer look! |
|
#162 still looking for reviews |
m6w6
added a commit
that referenced
this pull request
Aug 23, 2024
m6w6
added a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added support to use Msgpack as a serializer for APCu. This was needed to me because IgBinary is very unstable under PHP 7 (gives a Segmentation Fault whenever you try to use it as a session or APCu serializer) and I want to switch to the newer runtime version.
In the coming days I will do some more testing. If some of you have any suggestion on how to improve the pull request, I will be happy to fix it.
PS. I see the CI build fails for test 029 since it doesn't have APCu installed. Maybe I could add support for APC as well and update .travis.yml to use it. Let me know!
Thanks!