Add support deserializing the bin format family #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Der
force-pushed
the
support-bin-format-family
branch
from
fb7ecfa to
a0810e1
Compare
|
I am not sure about this neither.. maybe we could hold from committing this for now.... :< |
|
@laruence anything works for me! I am just trying to close out #36. Are there any issues that you think are important and well defined? (other msgpack implementations are at the same place as us so it would be nice to give people something to like this) |
|
hmm, then okey, commit it.. thanks :) |
|
Awesome, thanks @laruence! Also, do you have issues you would like me to look at in particular? I am going to look at the current test fails, then go through the issues oldest -> newest. |
|
Nope, please do whatever you want :), if you needs some discussions, just ping me , thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @laruence this is a WIP!
I am going to add tests for deserialization as well.
However, I don't know when we would want to serialize something with this format?