-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds method to hit the solar 'history' API endpoint. #306
Open
ArthurD
wants to merge
16
commits into
mseminatore:master
Choose a base branch
from
ArthurD:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokens issued via the v3 OAuth2 flow need to be renewed via the v3 refresh endpoint. Also update the new login flow to return the refersh token required (i.e. from "step 3" rather than "step 4") to successfully issue new tokens.
…mseminatore-master
V3 token refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic PR that is largely a copy/paste from the existing solar method/API call directly above it. This allows you to pull the 'solar history' for a given energy site (energy_site_id).
I used args instead of adding to the existing options object to avoid making any 'obtrusive' changes to existing code.
I have this in 'production' use and it's working well.
FYI / for potential documentation purposes, etc -- the new API call currently returns 2 days worth of day ("today" and "yesterday"), with the following being an example of the JSON returned:
JSON Results from API Endpoint:
https://gist.github.com/ArthurD/f688719e406a00db40f87a81f0592f87