Set number of dataloader workers to a sane default #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior default was the number of available CPUs which leads to issues for systems with large number of CPUs (e.g. DGX). This change introduces an optional argument "--num-workers" which defaults to 8. Signed-off-by: Steven Lang <[email protected]>
mseitzer
requested changes
Apr 18, 2021
- Add default (8) to num_workers method arguments - Fix wrong help string in argument parser Signed-off-by: Steven Lang <[email protected]>
|
Thanks for your fast response, I've incorporated the requested changes. |
mseitzer
added a commit
that referenced
this pull request
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior default was the number of available CPUs which leads to issues
for systems with a large number of CPUs (e.g. DGX).
This change introduces an optional argument "--num-workers"
which defaults to 8.
Signed-off-by: Steven Lang [email protected]