Add support for transaction codes (GV-Codes) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated example added web-functionality without callback; see example
Continuing any communication on a closed dialog results in errors, obviously. Clearing it will tell getDialog() to initialize a new dialog.
Firstly, it is weird to have a parameter that just calls another function, which the caller can call separately. Secondly, the proper way to end a dialog owned by FinTs is to call FinTs::end(), which also clears its local field. Note that getSEPAAccounts() reinitializes the same dialog for some reason. This commit leaves its behavior unchanged.
Correctly end dialogs after sync
We need a relatively old version because \PHPUnit_Framework_TestCase was replaced in v6.
Add PHPUnit as explicit dev dependency
Redesign segments, DEGs and how they are parsed/serialized mschindler83#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for transaction codes, a.k.a. Geschäftsvorfall-Code / GV-Code. It is based on #77 because it changes related code parts, mainly the regexp used by
MT940.php.