Skip to content

Commit

Permalink
Revert cockroachdb#98150 (2/2)
Browse files Browse the repository at this point in the history
Epic: none
Release note: None
  • Loading branch information
tbg committed Mar 27, 2023
1 parent 49d001d commit c46b8a6
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions pkg/kv/kvserver/replica_proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,14 @@ func (r *Replica) leasePostApplyLocked(
}
}

// Potentially re-gossip if the range contains node liveness data. We need to
// perform this gossip at startup as soon as possible. We also need to perform
// this gossip if we're taking over after a leaseholder failure. In both cases,
// incremental liveness updates may have been lost, so we want to make sure that
// the latest view of node liveness ends up in gossip.
if leaseChangingHands && iAmTheLeaseHolder {
// Potentially re-gossip if the range contains system data (e.g. system
// config or node liveness). We need to perform this gossip at startup as
// soon as possible. Trying to minimize how often we gossip is a fool's
// errand. The node liveness info will be gossiped frequently (every few
// seconds) in any case due to the liveness heartbeats. And the system config
// will be gossiped rarely because it falls on a range with an epoch-based
// range lease that is only reacquired extremely infrequently.
if iAmTheLeaseHolder {
// NB: run these in an async task to keep them out of the critical section
// (r.mu is held here).
_ = r.store.stopper.RunAsyncTask(r.AnnotateCtx(context.Background()), "lease-triggers", func(ctx context.Context) {
Expand Down

0 comments on commit c46b8a6

Please sign in to comment.