backupccl: avoid RAID0ing local NVMe and GP3 storage in restore roach…

…tests

A long restore roachtest perf investigation revealed that roachprod can RAID0
local storage and AWS GP3 storage, a configuration that does not mix well with
CRDB and does not reflect a reasonable customer environment. This patch avoids
this RAID0ing in the restore roachtests, stabilizing test performance.

Informs cockroachdb#98783

Fixes cockroachdb#97019

Release note: none

pkg/cmd/roachtest/tests/restore.go

@@ -411,7 +411,18 @@ func (hw hardwareSpecs) makeClusterSpecs(r registry.Registry) spec.ClusterSpec {
 	if hw.mem != spec.Auto {
 		clusterOpts = append(clusterOpts, spec.Mem(hw.mem))
 	}
-	return r.MakeClusterSpec(hw.nodes, clusterOpts...)
+	s := r.MakeClusterSpec(hw.nodes, clusterOpts...)
+
+	if s.Cloud == "aws" && s.VolumeSize != 0 {
+		// Work around an issue that RAID0s local NVMe and GP3 storage together:
+		// https://github.com/cockroachdb/cockroach/issues/98783.
+		//
+		// This should be removed once we have found a real solution that avoids
+		// ever creating such a RAID.
+		s.InstanceType = spec.AWSMachineType(s.CPUs, s.Mem)
+		s.InstanceType = strings.Replace(s.InstanceType, "d.", ".", 1)
+	}
+	return s
 }
 
 // String prints the hardware specs. If verbose==true, verbose specs are printed.