Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

Commit

Permalink
Showing and hiding the tabBarView manualy in viewWillAppear and viewW…
Browse files Browse the repository at this point in the history
…illDisappear, because the tabBarView in the MSSTabNavigationBar was never removed or hidden or the rect wasnot made to CGRectZero. Thats why the collectionView inside the MSSTabBarView was showing over the navigation bar in other places, where I dont need tabs. Specially when the NavigationBar is shown or hidden from the code for some pages, this bug definitely happens.
  • Loading branch information
Benzamin Basher authored and Benzamin Basher committed Mar 9, 2017
1 parent 534e52a commit 45c5d6b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Source/MSSTabbedPageViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ - (void)viewWillAppear:(BOOL)animated {
tabBarView.dataSource = self;
tabBarView.delegate = self;
self.tabBarView = tabBarView;
self.tabBarView.hidden = NO;

BOOL isInitialController = (self.navigationController.viewControllers.firstObject == self);
[navigationBar tabbedPageViewController:self viewWillAppear:animated isInitial:isInitialController];
Expand All @@ -64,6 +65,7 @@ - (void)viewWillDisappear:(BOOL)animated {
}

// remove the current tab bar
self.tabBarView.hidden = YES;
self.tabBarView = nil;
}
}
Expand Down

0 comments on commit 45c5d6b

Please sign in to comment.