Merge branch 'main' of https://github.com/hashicorp/terraform-provide…

…r-azurerm into managed-grafana

.github/workflows/depscheck.yaml

@@ -16,7 +16,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-         go-version: '1.18.1'
+         go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
-      - run: make tools
       - run: make depscheck

.github/workflows/gencheck.yaml

@@ -20,7 +20,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
-      - run: make tools
       - run: make gencheck

.github/workflows/golint.yaml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - uses: golangci/golangci-lint-action@v2
         with:
           version: 'v1.45.0'

.github/workflows/gradually-deprecated.yaml

@@ -16,5 +16,5 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: ./scripts/run-gradually-deprecated.sh

.github/workflows/issue-comment-created.yaml

@@ -4,6 +4,10 @@ on:
   issue_comment:
     types: [created]
 
+permissions:
+  pull-requests: write
+  issues: write
+
 jobs:
   issue_comment_triage:
     runs-on: ubuntu-latest
@@ -22,9 +26,10 @@ jobs:
         with:
           github_token: "${{ secrets.GITHUB_TOKEN }}"
           labels: waiting-response
-      - name: "Add waiting-response"
-        if: "contains(github.event.comment.body, ' /wr')"
-        shell: bash
+  pull_request_comment:
+    runs-on: ubuntu-latest
+    if: github.event.issue.pull_request && endsWith(github.event.comment.body, '/wr')
+    steps:
+      - shell: bash
         run: |
           curl -X POST -H "Accept: application/vnd.github+json" -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" "https://api.github.com/repos${{ github.owner }}/${{ github.repository }}/issues/${{ github.event.issue.number }}/labels" -d '{"labels":["waiting-response"]}'
-

.github/workflows/link-milestone.yaml

@@ -16,7 +16,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: |
           go install github.com/stephybun/link-milestone@latest
           link-milestone

.github/workflows/pull-request-new-commit.yaml

@@ -2,14 +2,17 @@
 name: Pull Request New Commit
 
 on:
-  pull_request:
+  pull_request_target:
     types: [synchronize]
 
+permissions:
+  pull-requests: write
+
 jobs:
   issue_comment_triage:
     runs-on: ubuntu-latest
     steps:
       - uses: actions-ecosystem/action-remove-labels@v1
         with:
           github_token: "${{ secrets.GITHUB_TOKEN }}"
-          labels: waiting-response
+          labels: waiting-response

.github/workflows/pull-request-reviewed-workflow.yaml

@@ -0,0 +1,48 @@
+---
+name: "Pull Request Reviewed Workflow"
+
+on:
+  workflow_run:
+    workflows:
+      - "Pull Request Reviewed"
+    types:
+      - completed
+
+permissions:
+  pull-requests: write
+
+jobs:
+  add-or-remove-waiting-response:
+    runs-on: ubuntu-latest
+    outputs:
+      ghrepo: ${{ steps.env_vars.outputs.ghrepo }}
+      ghowner: ${{ steps.env_vars.outputs.ghowner }}
+      prnumber: ${{ steps.env_vars.outputs.prnumber }}
+      action: ${{ steps.env_vars.outputs.action }}
+    steps:
+      - name: Get Artifact
+        id: get_artifact
+        continue-on-error: true
+        uses: dawidd6/action-download-artifact@v2
+        with:
+          github_token: ${{secrets.GITHUB_TOKEN}}
+          workflow: pull-request-reviewed.yaml
+
+      - name: env_vars
+        id: env_vars
+        if: steps.get_artifact.outcome == 'success'
+        run: |
+          echo "::set-output name=ghrepo::$(cat artifact/ghrepo.txt)"
+          echo "::set-output name=ghowner::$(cat artifact/ghowner.txt)"
+          echo "::set-output name=prnumber::$(cat artifact/prnumber.txt)"
+          echo "::set-output name=action::$(cat artifact/action.txt)"
+
+      - name: add waiting-reponse
+        if: steps.get_artifact.outcome == 'success' && steps.env_vars.outputs.action == 'add-waiting-response'
+        run: |
+          curl -X POST -H "Accept: application/vnd.github+json" -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" "https://api.github.com/repos${{ steps.env_vars.outputs.ghowner }}/${{ steps.env_vars.outputs.ghrepo }}/issues/${{ steps.env_vars.outputs.prnumber }}/labels" -d '{"labels":["waiting-response"]}'
+
+      - name: remove waiting-reponse
+        if: steps.get_artifact.outcome == 'success' && steps.env_vars.outputs.action == 'remove-waiting-response'
+        run: |
+          curl -X DELETE -H "Accept: application/vnd.github+json" -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" "https://api.github.com/repos${{ steps.env_vars.outputs.ghowner }}/${{ steps.env_vars.outputs.ghrepo }}/issues/${{ steps.env_vars.outputs.prnumber }}/labels/waiting-response"

.github/workflows/pull-request-reviewed.yaml

@@ -5,12 +5,32 @@ on:
   pull_request_review:
     types: [submitted]
 
+permissions:
+  pull-requests: read
+
 jobs:
-  add-waiting-response:
-    if: github.event.review.state != 'approved'
+  add-or-remove-waiting-response:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/labeler@v3
+      - name: "Set Artifacts for add-waiting-response"
+        if: github.event.review.state != 'approved' && github.actor != github.event.pull_request.user.login
+        shell: bash
+        run: |
+          mkdir -p wr_actions
+          echo ${{ github.owner }} > wr_actions/ghowner.txt
+          echo ${{ github.repository }} > wr_actions/ghrepo.txt
+          echo ${{ github.event.pull_request.number }} > wr_actions/prnumber.txt
+          echo "add-waiting-response" > wr_actions/action.txt
+      - name: "Set Artifacts for remove-waiting-response"
+        if: github.actor == github.event.pull_request.user.login
+        shell: bash
+        run: |
+          mkdir -p wr_actions
+          echo ${{ github.owner }} > wr_actions/ghowner.txt
+          echo ${{ github.repository }} > wr_actions/ghrepo.txt
+          echo ${{ github.event.pull_request.number }} > wr_actions/prnumber.txt
+          echo "remove-waiting-response" > wr_actions/action.txt                
+      - uses: actions/upload-artifact@v3
         with:
-          configuration-path: .github/waiting-response.yml
-          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          name: artifact
+          path: wr_actions

.github/workflows/tflint.yaml

@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
       - run: make tools
       - run: make tflint

.github/workflows/thirty-two-bit.yaml

@@ -20,7 +20,6 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
-      - run: make tools
       - run: GOARCH=386 GOOS=linux go build -o 32bitbuild .

.github/workflows/unit-test.yaml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
       - run: make test
         env:

.github/workflows/validate-examples.yaml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
       - run: make tools
       - run: make validate-examples

.github/workflows/website-lint.yaml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.18.1'
+          go-version: '1.18.5'
       - run: bash scripts/gogetcookie.sh
       - run: make tools
       - run: make website-lint

.go-version

@@ -1 +1 @@
-1.18.1
+1.18.5

CHANGELOG.md

@@ -1,15 +1,69 @@
-## 3.17.0 (Unreleased)
+## 3.19.0 (Unreleased)
+
+FEATURES:
+
+* **New Data Source**: `azurerm_dns_a_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_aaaa_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_caa_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_cname_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_mx_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_ns_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_ptr_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_soa_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_srv_record` [GH-17477]
+* **New Data Source**: `azurerm_dns_txt_record` [GH-17477]
+
+ENHANCEMENTS:
+
+* updating `dedicated_host_*` to use `hashicorp/go-azure-sdk` [GH-17616]
+* Data Source: `azurerm_images` - now uses a logical id [GH-17766]
+* `azurerm_key_vault` - support for the `public_network_access_enabled` property [GH-17552]
+* `azurerm_mssql_elastic_pool` - support for the `maintenance_configuration_name` property [GH-17790]
+
+BUG FIXES:
+
+* `azurerm_data_protection_backup_policy_postgresql_resource` - prevent a crash when given an empty criteria block [GH-17904]
+* `azurerm_disk_encryption_set` - prevent an issue during creation when the disk encryption set and key vault are in different subscriptions [GH-17964]
+
+## 3.18.0 (August 11, 2022)
+
+FEATURES: 
+
+* **New Resource**: `azurerm_monitor_data_collection_endpoint` ([#17684](https://github.com/hashicorp/terraform-provider-azurerm/issues/17684))
+
+ENHANCEMENTS:
+
+* dependencies: updating `github.com/hashicorp/go-azure-sdk` to `v0.20220809.1122626` ([#17905](https://github.com/hashicorp/terraform-provider-azurerm/issues/17905))
+* storage: updating to use API Version `2021-09-01` ([#17523](https://github.com/hashicorp/terraform-provider-azurerm/issues/17523))
+* `azurerm_express_route_circuit_peering` - support for the `ipv4_enabled` and `gateway_manager_etag` properties ([#17338](https://github.com/hashicorp/terraform-provider-azurerm/issues/17338))
+* `azurerm_site_recovery_replicated_vm` - support for the `target_disk_encryption` block ([#15783](https://github.com/hashicorp/terraform-provider-azurerm/issues/15783))
+* `azurerm_subnet` - deprecate `enforce_private_link_endpoint_network_policies` property in favour of `private_endpoint_network_policies_enabled` ([#17464](https://github.com/hashicorp/terraform-provider-azurerm/issues/17464))
+* `azurerm_subnet` - deprecate `enforce_private_link_service_network_policies` property in favour of `private_link_service_network_policies_enabled` ([#17464](https://github.com/hashicorp/terraform-provider-azurerm/issues/17464))
+* `azurerm_servicebus_subscription` - support for the `client_scoped_subscription_enabled` property and the `client_scoped_subscription` block ([#17101](https://github.com/hashicorp/terraform-provider-azurerm/issues/17101))
+
+BUG FIXES:
+
+* `azurerm_backup_policy_vm` - now prevents crash when `frequency` is set to Hourly and, `hour_interval` and `hour_duration`are not set ([#17880](https://github.com/hashicorp/terraform-provider-azurerm/issues/17880))
+* Data Source: `azurerm_blueprint_definition` - Fix `version` property output ([#16299](https://github.com/hashicorp/terraform-provider-azurerm/issues/16299))
+
+## 3.17.0 (August 04, 2022)
 
 ENHANCEMENTS:
 
-* Data Source: `azurerm_proximity_placement_group` - refactoring to use `hashicorp/go-azure-sdk` [GH-17776]
-* `azurerm_linux_virtual_machine_scale_set` - the property `instances` is now Optional and defaults to `0` [GH-17836]
-* `azurerm_log_analytics_cluster` - updated validation for the `size_gb` property [GH-17780]
-* `azurerm_proximity_placement_group` - refactoring to use `hashicorp/go-azure-sdk` [GH-17776]
+* domainservice: updating to use API Version `2021-05-01` ([#17737](https://github.com/hashicorp/terraform-provider-azurerm/issues/17737))
+* Data Source: `azurerm_proximity_placement_group` - refactoring to use `hashicorp/go-azure-sdk` ([#17776](https://github.com/hashicorp/terraform-provider-azurerm/issues/17776))
+* `azurerm_api_management` - update the `sku_name` property validation to accept newer Premium SKUs ([#17887](https://github.com/hashicorp/terraform-provider-azurerm/issues/17887))
+* `azurerm_firewall` - the property `sku_tier` is now updateable ([#17577](https://github.com/hashicorp/terraform-provider-azurerm/issues/17577))
+* `azurerm_linux_virtual_machine_scale_set` - the property `instances` is now Optional and defaults to `0` ([#17836](https://github.com/hashicorp/terraform-provider-azurerm/issues/17836))
+* `azurerm_log_analytics_cluster` - updated validation for the `size_gb` property ([#17780](https://github.com/hashicorp/terraform-provider-azurerm/issues/17780))
+* `azurerm_proximity_placement_group` - refactoring to use `hashicorp/go-azure-sdk` ([#17776](https://github.com/hashicorp/terraform-provider-azurerm/issues/17776))
+* `azurerm_shared_image` - improved validation for the `publisher`, `offer` and `sku` properties in the `identifier` block ([#17547](https://github.com/hashicorp/terraform-provider-azurerm/issues/17547))
+* `azurerm_subnet` - support for the service delegation `Microsoft.Orbital/orbitalGateway` ([#17854](https://github.com/hashicorp/terraform-provider-azurerm/issues/17854))
+* `azurerm_eventhub_namespace` - support for the `local_authentication_enabled`, `public_network_access_enabled`, and `minimum_tls_version` properties ([#17194](https://github.com/hashicorp/terraform-provider-azurerm/issues/17194))
 
 BUG FIXES:
 
-* Data Source: `azurerm_private_dns_zone` - returning the correct Resource ID when not specifying the `resource_group_name` [GH-17729]
+* Data Source: `azurerm_private_dns_zone` - returning the correct Resource ID when not specifying the `resource_group_name` ([#17729](https://github.com/hashicorp/terraform-provider-azurerm/issues/17729))
 
 ## 3.16.0 (July 28, 2022)
 

contributing/topics/guide-opening-a-pr.md

@@ -54,6 +54,7 @@ Examples of good PR titles:
 
 - `azurerm_storage_management_policy - Mark rule.filters.blob_type as required`
 - `azurerm_container_registry - support updating replications on demand`
+- `azurerm_automation_account - support for the encrytion, local_authentication_enabled, and tags properties`
 - `Data Source: azurerm_automation_account - prevent panic (#15474) by adding a nil check`
 - `Upgrade bot API version from 2021-03-01 to 2021-05-01-preview`
 - `New Resource: azurerm_managed_disk_sas_token`
@@ -68,6 +69,7 @@ Examples of poorly written PR titles:
 - `upgrade sdk`
 - `upgrade compute api`
 - `add cosmos property`
+- `support encryption, local_authentication_enabled properties`
 
 ### Description
 
@@ -77,4 +79,4 @@ It should also link to any related issues/PRs and include the following for any
 
  ```
  fixes #1234,#5678
- ```
+ ```

examples/private-endpoint/private-link-scope/README.md

@@ -0,0 +1,9 @@
+## Example: Private Endpoint
+
+This example provisions a Private Endpoint which connects to a Private Link Scope within Azure.
+
+### Variables
+
+* `prefix` - (Required) The prefix used for all resources in this example.
+
+* `location` - (Required) The Azure Region in which all resources in this example should be created.