add bundle.go to verify a bundle #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liangchenye <[email protected]>
| } | ||
|
|
||
| if _, ok := rmps[mps[index].Name]; !ok { | ||
| logrus.Fatalf("%s in config/mount is not exist in runtime/mount", mps[index].Name) |
Signed-off-by: liangchenye <[email protected]>
|
Updated, Thanks! |
| logrus.Fatal(err) | ||
| } else { | ||
| if spec.Platform.OS != "linux" { | ||
| logrus.Fatalf("The operation system '%s' of the bundle is not support yet.", spec.Platform.OS) |
Signed-off-by: liangchenye <[email protected]>
| @@ -14,6 +14,7 @@ VERSION: | |||
|
|
|||
| COMMANDS: | |||
| generate generate a OCI spec file | |||
| bundleValidate verify if a bundle was valid | |||
Signed-off-by: liangchenye <[email protected]>
|
Thanks! I will test this out today. |
| } | ||
|
|
||
| bundleValidate(spec, runtime, path.Join(inputPath, "rootfs")) | ||
| logrus.Infof("Bundle test succeeded.") |
| logrus.Fatal(err) | ||
| } | ||
|
|
||
| bundleValidate(spec, runtime, path.Join(inputPath, "rootfs")) |
There was a problem hiding this comment.
This cannot be assumed. This should be read from root/path in config.json
|
Also, I tried testing this with rootfs.tar.gz in this repo and it doesn't work. Could you modify the rootfs so that bundleValidate works with it? |
|
Re: updating rootfs.tar.gz, see #14. |
Signed-off-by: liangchenye <[email protected]>
|
close and PR to opencontainers/ocitools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: liangchenye [email protected]