Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compatible with rspack #501

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Oct 11, 2023

Use compiler.webpack.DefinePlugin instead of require from webpack, this is also available way in webpack, and can be compatible with rspack.

This can also avoid requiring wrong webpack when using monorepo and have multiple webpack in node_modules

@hardfist
Copy link

and this is more friendly to monorepo

@xc2
Copy link

xc2 commented Mar 18, 2024

hi @mrsteele sry for ping you, but it seems that this pr is ready for merging. Could you please help merge and release a new version?

@mrsteele
Copy link
Owner

Any chance you ran tests? I want to make sure it’s compatible with previous versions of webpack/node.

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Mar 19, 2024

Didn't notice webpack4 don't have compiler.webpack. Fixed it and now it should compatible with webpack4, and all tests pass in my local

@mrsteele mrsteele merged commit c6ebc71 into mrsteele:master Mar 20, 2024
1 check passed
Copy link

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xc2
Copy link

xc2 commented Mar 22, 2024

thank you all @ahabhgk @mrsteele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants