Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15 - Add advanced configuration options for piwik analytics. #18

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

ruKurz
Copy link

@ruKurz ruKurz commented Jun 14, 2017

[NEW] Added sub domain piwik settings to RC admin UI.
@RocketChat/core

Closes #15

bildschirmfoto 2017-06-14 um 15 52 47

- Removed unnecessary code for setting a custom tracking url
- Make the list of domains editable
- Changed comment
@ruKurz ruKurz self-assigned this Jun 14, 2017
@ruKurz ruKurz requested a review from mrsimpson June 14, 2017 13:54
Copy link
Owner

@mrsimpson mrsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Eslint wants arrays to be const if there's no re-assignment. I don't like that view, if elements of the array are added or removed. I'd suggest to except it.

@mrsimpson mrsimpson merged commit b85982a into develop Jun 14, 2017
@ruKurz ruKurz added this to the basic milestone Jun 20, 2017
@mrsimpson mrsimpson deleted the feature/15-piwik-analytics branch June 22, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants