Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add md5 function #29

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jeffbrennan
Copy link

@jeffbrennan jeffbrennan commented Sep 11, 2024

addresses #21

I have a working implementation of an appended md5 column using the standard library hashlib.md5 function.

This likely won't work on larger tables as implementation includes a pylist collection and a list comprehension where the md5 hash is computed per-value before being appended to the pyarrow table.

Open to suggestions for improvement!


One thing that is currently unhandled is columns containing null values. The binary_join_element_wise documentation has support for

  1. emitting a null for the full concatenation (default)
  2. skipping the null element
  3. replacing the null element with a string

I'm in favor of either 2 or 3 - let me know your thoughts

@jeffbrennan
Copy link
Author

@MrPowers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant