-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Safe atomic core/
lib with configure { config -> ... }
API for Android
#1996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
mrousavy
changed the title
feat: Android
feat: Safe atomic Oct 16, 2023
core/
lib with configure { config -> ... }
APIcore/
lib with configure { config -> ... }
API for Android
mrousavy
added
🤖 android
Issue affects the Android platform
✨ feature
Proposes a new feature or enhancement
labels
Oct 16, 2023
This was referenced Oct 16, 2023
Closing in favor of #2049 - new base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactors the Android codebase to use a similar API to the iOS
Core/
codebase, where every Camera option can be set within a singleconfigure
call.Internally, this properly locks the Mutex/Hardware so that only one Configure call can happen at a time, and then it diffs the configuration before vs after to figure out what actually needs to be reconfigured.
Benefits
PreviewView
asynchronously be created and destroyed, React props being updated, or the Camera being disconnected - all potentially at the same time causing collisions.This would fix errors like "Configuration contains unconfigured input/output Surfaces" or "Surface abandoned!"
configure
override old calls if the old calls still haven't executed yet, making it faster in cases where the Hardware is a bit slower than the Softwareconfiguration
be dynamically computed under a lock, meaning we have a single source of truth. Ifconfiguration.isActive
istrue
, the Camera is definitely running.core/
library ("VisionCamera") could be extracted and released as a native Java/Kotlin Android Camera library (or a Flutter library), it is not tightly bound to React Native anymore.Things to test
Changes
Tested on
Related issues