Add auto-update feature and improve code #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Add auto update capability using OneUpdater • Refactor workflowHandler.sh by using Alfred's environment variables • Fix Shellcheck issues • Minor changes in README
xilopaint
changed the title
|
In order to make the auto-update feature work you have to make a new release with the tag v1.1. |
|
@xilopaint this looks really good. There is however still a failing unit test. |
|
Sorry! I forgot to run the unit tests. Now everything is ok. Also, I added support to DNS.WATCH and Cloudflare DNS servers. |
|
Great job. I will push to a new release. Thank you. |
There's an error in release notes. The new auto-update method doesn't depend on Packal. OneUpdater is a totally separate solution. Packal is no longer maintained and doesn't work for updates anymore. |
|
Thank you for bringing this to my attention. I have updated the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Add auto update capability using OneUpdater
• Refactor workflowHandler.sh by using Alfred's environment variables
• Fix Shellcheck issues
• Minor changes in README