Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEthernetName improvement #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jankkm
Copy link

@jankkm jankkm commented Mar 22, 2024

Ethernet device names can be customised which broke some of the functionality. Now this is fixed.

jankkm added 2 commits March 22, 2024 11:48
Ethernet device names can be customised which broke some of the functionality. Now this is fixed.
Allow ethernet devices higher than en9
@mrodalgaard
Copy link
Owner

Hi @jankkm,

Great work with the PR, but I need some comments on what you are matching with sed -n "/Device: $(getEthernetInterface))$/{x;p;d;}; x" | sed -e 's/^([0-9]*) \(.*\)$/\1/') and grep -m 1 -o -e 'en[0-9]\{1,3\}'.

Above needs to be covered by test cases. I can help with that, once we have a good description of what you want to achieve.

Also tests are failing for matching Thunderbolt Ethernet and AX88179A, so the extraction needs to be tweaked a little to match all caes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants