Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vue file basic support #103

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Conversation

yoyo930021
Copy link
Contributor

@yoyo930021 yoyo930021 commented Dec 12, 2019

Add .vue file basic support, refer to vetur for implementation. fix #66

  • add unit test
  • add e2e test.

@yoyo930021 yoyo930021 changed the title WIP: feat: add vue file basic support feat: add vue file basic support Dec 12, 2019
@sdaitzman
Copy link

Thank you for the awesome work on this!! 💯

Copy link
Owner

@mrmlnc mrmlnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! 🎉

I marked the important issues for the merging with a 🚫 emoji. After the fix, I'm ready to release a new version of the extension.

src/server.ts Outdated Show resolved Hide resolved
src/client.ts Show resolved Hide resolved
src/utils/vue.ts Outdated Show resolved Hide resolved
src/utils/vue.ts Outdated Show resolved Hide resolved
@mrmlnc mrmlnc added this to the 0.9.0 milestone Jan 4, 2020
@mrmlnc mrmlnc self-assigned this Jan 4, 2020
@yoyo930021
Copy link
Contributor Author

@mrmlnc
This project unit test is broken when e1a9878.
From 73 passing to 2 passing. QAQ

@yoyo930021
Copy link
Contributor Author

yoyo930021 commented Jan 5, 2020

@mrmlnc
This project unit test is broken when e1a9878.
From 73 passing to 2 passing. QAQ

mochajs/mocha#4096 (comment)
I fix it.

Copy link
Owner

@mrmlnc mrmlnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @yoyo930021.

I will try to release a new version on this week.

package.json Show resolved Hide resolved
@mrmlnc mrmlnc merged commit b9cea88 into mrmlnc:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for vue files (variable suggestions, mixins etc.)
3 participants