Support for Java language #367
Conversation
Docker image for Java evaluator.
|
Hi, thanks, this looks good! Do you perhaps have some Java test project with the intended layout (e.g. a set of Java files, Maven configuration file, etc.), so that I could test it locally? |
Hi, thank you. You can use this example. |
There was a problem hiding this comment.
Apart from the mentioned nits, I have also pushed two changes that we need to make to properly support the Java pipeline.
I haven't tested tests, but build of the linked example project looks fine. The build log is quite… verbose, so it might be nice to hide it by default in a <details> HTML tag, like is being done for Rust (like this). But it's just a nice-to-have thing.
kozusznik
force-pushed
the
master
branch
3 times, most recently
from
221307f to
a0a0900
Compare
This commit address comments from the pull request: -replace some packages installed in docker image (in Dockerfile) -fix errors and remove unused variables from the file entry.py
|
Thank you again for the review. I addresed all comments. |
Docker image for Java evaluator.