Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit upgrade guacamole version #40

Merged

Conversation

roumano
Copy link
Collaborator

@roumano roumano commented Jan 10, 2024

Hi @mrlesmithjr ,

actually as the binary compiled is already existing, this ansible role never updating the guacamole version

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

actually as the binary compiled is already existing, it's never updating
the guacamole version
@mrlesmithjr
Copy link
Owner

@roumano - I added you as a collaborator to this repo, so you don't have to wait on me, and your contributions are greatly appreciated.

@roumano
Copy link
Collaborator Author

roumano commented Jan 11, 2024

Thanks i will accept my merge request and try to keep alive this repo , ...

where / how we can discuss for some specific issue/request ? ( on a issue ? )

like the 1.5.4 refuse to compile and my workarround is this :

- name: install | Configuring Guacamole Server Build # noqa no-changed-when
  ansible.builtin.command: ./configure --with-init-dir=/etc/init.d --disable-guacd
  args:
    chdir: "{{ guacamole_src_dir + '/guacamole-server-' + guacamole_version }}"
  become: true
  register: _guacamole_config_server_build
  when: not _guacamole_server_installed['stat']['exists'] or extract.changed
# Workarround for this bug in 1.5.4 : https://lists.apache.org/thread/h5zql3zdov0ngh8kp9r3yppcprq5z1jf
  environment:
    LDFLAGS: '-lrt'

but i'm not sure it's a good idea to enable to for all version and all OS

@roumano roumano merged commit ce9c62f into mrlesmithjr:master Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants