Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old extensions (if any) #34

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

roumano
Copy link
Collaborator

@roumano roumano commented Nov 6, 2023

Will fix issue #30 : Old extension are never cleaned

Description

It's removing previous guacamole extension

Related Issue

Will fix issue #30 : Old extension are never cleaned

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Owner

@mrlesmithjr mrlesmithjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roumano - I think we need to add a conditional of some sort to control whether or not these tasks are executed. Furthermore, these tasks will run on each subsequent run which is likely not what we want.

@roumano
Copy link
Collaborator Author

roumano commented Nov 10, 2023 via email

@mrlesmithjr
Copy link
Owner

@roumano Can you rebase with master? I have fixed the linting issues with GitHub Actions on #35

Will fix issue mrlesmithjr#30 : Old extension are never cleaned
@mrlesmithjr mrlesmithjr merged commit ed66fb4 into mrlesmithjr:master Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants