Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect NO_COLOR #211

Closed
mrgrain opened this issue Aug 13, 2022 · 0 comments · Fixed by #213
Closed

Respect NO_COLOR #211

mrgrain opened this issue Aug 13, 2022 · 0 comments · Fixed by #213
Labels
enhancement New feature or request

Comments

@mrgrain
Copy link
Owner

mrgrain commented Aug 13, 2022

esbuild doesn't seem to do this by itself. We should read the env var and pass it on to the color option by default.
@mrgrain mrgrain added the enhancement New feature or request label Aug 13, 2022
@mrgrain mrgrain changed the title Respect NO_COLOR Respect NO_COLOR Aug 13, 2022
mrgrain added a commit that referenced this issue Aug 13, 2022
@mrgrain
feat: support NO_COLOR
a7084a8 
Fixes #211
@mrgrain mrgrain mentioned this issue Aug 13, 2022
Merged
mrgrain added a commit that referenced this issue Aug 13, 2022
@mrgrain
feat: support NO_COLOR (#213)
e0a8089 
Fixes #211
mrgrain added a commit that referenced this issue Aug 13, 2022
@mrgrain
feat: support NO_COLOR (#213)
7df3ac0 
Fixes #211
mrgrain added a commit that referenced this issue Aug 13, 2022
@mrgrain
feat: support NO_COLOR (#213)
1abd267 
Fixes #211
@mrgrain mrgrain mentioned this issue Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support NO_COLOR mrgrain/cdk-esbuild
1 participant
@mrgrain