Skip to content

Commit

Permalink
feat: deprecate Docker bundler
Browse files Browse the repository at this point in the history
The docker bundler will be remove in v2. Usage of it is deprecated and you should use `BundlerPriority.LocalOnly` to be prepared.
  • Loading branch information
Momo Kornher committed Oct 17, 2021
1 parent 0ddb6d0 commit 6715463
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/asset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export interface EsbuildAssetProps extends Partial<IAsset> {
* Priority order of available bundlers. Defaults to attempt local first, then docker.
*
* @default BundlerPriority.AttemptLocal
* @deprecated "Docker support will be removed in v2. Set to `BundlerPriority.LocalOnly` to be prepared."
*/
bundlerPriority?: BundlerPriority;

Expand Down Expand Up @@ -75,7 +76,7 @@ abstract class Asset<Props extends EsbuildAssetProps> extends S3Asset {
{
priority: bundlerPriority,
copyDir,
}
},
),
});
}
Expand Down
3 changes: 3 additions & 0 deletions lib/bundlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export type BuildOptions = MarkRequired<EsbuildOptions, "entryPoints">;
export enum BundlerPriority {
/**
* Only use the Docker bundler
* @deprecated "Docker support will be removed in v2. Set to `BundlerPriority.LocalOnly` to be prepared."
*/
DockerOnly,

Expand All @@ -26,6 +27,7 @@ export enum BundlerPriority {

/**
* Attempts to first use the local bundler, only use Docker bundler if local fails.
* @deprecated "Docker support will be removed in v2. Set to `BundlerPriority.LocalOnly` to be prepared."
*/
AttemptLocal,
}
Expand All @@ -48,6 +50,7 @@ export interface BundlerProps {
* Priority order of available bundlers. Defaults to attempt local first, then docker.
*
* @default BundlerPriority.AttemptLocal
* @deprecated "Docker support will be removed in v2. Set to `BundlerPriority.LocalOnly` to be prepared."
*/
priority?: BundlerPriority;
}
Expand Down

0 comments on commit 6715463

Please sign in to comment.