Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS of registered tickets starting with 0 pronounced incorrectly #174

Closed
Ruuji187 opened this issue Jul 8, 2020 · 4 comments
Closed

TTS of registered tickets starting with 0 pronounced incorrectly #174

Ruuji187 opened this issue Jul 8, 2020 · 4 comments
Labels

Comments

@Ruuji187
Copy link

Ruuji187 commented Jul 8, 2020

It reads "001" as "O-O-One". Could be better if it reads it as "One".
Example: "040" is announced as "O-Four-O". It should be announced as "Forty".

@mrf345 mrf345 added the 0.8.1 0.8.1 release label Jul 8, 2020
@mrf345
Copy link
Owner

mrf345 commented Jul 8, 2020

I'm not able to reproduce the issue. I tested it in English and Arabic seems to work as expected. Also the system should start incrementing tickets from 100 so you should never face a scenario where a ticket is 001 or 010, same with the offices numbers if you enter 030 it will automatically change it to 30 and it's pronounced correctly.

  • What version of FQM you're running ?
  • What languages are you using ? is the issue reproducible with English ?
  • Can you include a screenshots or steps on how to reproduce the issue ?

Update: i was able to reproduce the issue, using numeric registered tickets. and inserting 001 manually.

@mrf345 mrf345 added question and removed question labels Jul 8, 2020
@mrf345 mrf345 changed the title Text-to-Speech TTS of registered tickets starting with 0 pronounced incorrectly Jul 8, 2020
@mrf345
Copy link
Owner

mrf345 commented Jul 8, 2020

@Ruuji187 i'm about to merge a PR #178 that resolves it. Please let me know if the issue still persists.

@mrf345 mrf345 closed this as completed in d6d3151 Jul 8, 2020
mrf345 added a commit that referenced this issue Jul 8, 2020
Remove 0 noise from registered tickets. Resolves #174
@Ruuji187
Copy link
Author

Ruuji187 commented Jul 8, 2020 via email

@mrf345
Copy link
Owner

mrf345 commented Jul 9, 2020

Supporting custom TTS announcements is not implemented yet , probably won't be anytime soon. You can us Customization > Aliases instead, but it doesn't support any language other than English currently, feel free to open another issue if you wan to add support for another language.

Most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants