add bubbling and propagation of events throughout Object3D tree #8368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.editorconfig
Outdated
| @@ -0,0 +1,3 @@ | |||
| [*.js] | |||
|
Thanks for your feedback @mrdoob, I've made the changes you suggested and squashed the commits. :) |
|
Adding this to the examples would be really helpful, I think. |
|
Agreed! Would it be possible to add an example to show this? |
|
Hey! I've finally added an example to this. I'm not sure if the title and category is clear enough. What do you guys think? |
|
Are there any plans to merge this, @mrdoob ? :) I see that GitHub now says that "This branch has conflicts that must be resolved", I could have a look and fix them if you want to. Cheers! |
|
Does anybody work on this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed on issue #8365, this pull-request enhances event handling on Object3D trees.
It handles
bubblesevent attribute and addsstopPropagation()method, only for events triggered fromObject3Dinstances - this feature doesn't make sense for other kind of objects such asMaterial,Texture, etc, AFAIK.There's a simple test case for this on
test/unit/core/Object3D.js.It would be great to use the native
Event/CustomEventfor this feature in the future - which might break existing applications though.Feedback are welcome!
Thanks