blender exporter breaks when parent contains keyframe animation and child does not #8061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…themselves contain keyframe animations, break the exporter
|
I'm not sure if blender's behavior has changed, since it's hard to believe that this wouldn't have come up before. I'm using blender 2.75, for reference. |
mrdoob
added a commit
that referenced
this pull request
Feb 7, 2016
blender exporter breaks when parent contains keyframe animation and child does not
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects with parents containing keyframe animations, but which don't themselves contain keyframe animations, break the exporter. This small patch adds a check that the animation object and action are not NoneType, returning an empty animation when they are. It is common to animate a parent object with children which remain stationary relative to the parent.